[20:33:10] <iran> I was fixing up my building revival plugin and I got everything working now for maps without duplicate structures, one issue though:
[20:33:40] <iran> after reviving a building on the server the IsDestroyed flag is still set to true on clients unless they restart
[20:34:59] <iran> i ran the client under a debugger and I set BuildingGameObj offset 0x778 (which contains a IsDestroyed bool flag) to false on the hand after reviving it
[20:35:44] <iran> this allowed me to buy infantry again, but there is no way to set the IsDestroyed flag for clients via the server
[20:36:47] <iran> *hand of nod after reviving it
[20:37:14] <iran> the IsDestroyed flag not syncing with the server affects the follow things I've seen:
[20:37:32] <iran> 1. Can't buy from revived production facilities
 2. no death announcement is made for revived building (damage announcements still work)

void Set_Object_Dirty_Bit_All(BaseControllerClass *Base, DIRTY_BIT Bit, bool Set)
{
    for (int i = 1; i < 0x80; i++)
    {
        if (Set)
        {
            Base->DirtyBits[i] |= Bit;
        }
        else
        {
            Base->DirtyBits[i] &= ~Bit;
        }
    }
}

void Restore_Building(GameObject *obj)
{
    if (!Commands->Get_ID(obj) || !obj)
    {
        return;
    }
    GameObject *o = As_BuildingGameObj(obj);
    if (!o)
    {
        return;
    }
    char *c = (char *)obj;
    c += 0x778;
    bool *x = (bool *)c; //Is building destroyed bool
    *x = false; //Make it false

    BaseControllerClass *b = BaseControllerClass::Find_Base(Get_Object_Type(o));
    if (b && !Is_Building_Dead(obj)) 
    {
        if (Is_SoldierFactory(o))
        {
            b->CanGenerateSoldiers = true;
        }
        else if (Is_WarFactory(o) || Is_Airstrip(o))
        {
            b->CanGenerateVehicles = true;
        }
        else if(Is_PowerPlant(o))
        {
            b->IsPowered = true;
        }
        Set_Object_Dirty_Bit_All(b, DB_RARE, true);

        float max = Commands->Get_Max_Health(o);
        Commands->Set_Health(obj, max);
    }
}

void Revive_Building(GameObject *Building)
{
	if (Building == nullptr ) return;
	if ( Is_Building_Dead(Building) == false ) return;

	int Team = ((DamageableGameObj*)Building)->Get_Player_Type();

	Restore_Building(Building);

	Building->Set_Object_Dirty_Bit(NetworkObjectClass::BIT_CREATION, true);
	Update_Network_Object(Building);

	float max = Commands->Get_Max_Health(Building);
	Commands->Set_Health(Building, max);

	// This is needed to update the state of a building from 'dead' to 'alive on the client
	Update_Network_Object(Building);
	Commands->Apply_Damage(Building, 1.0f, "Explosive", 0);
	Update_Network_Object(Building);

	Commands->Apply_Damage(Building, 1.0f, "Explosive", 0); 
	Update_Network_Object(Building);

	if (Is_Base_Powered(Team)) { Commands->Set_Building_Power(Building, true); }
	else { Commands->Set_Building_Power(Building, false); }

	GameObject *Ref = Find_Refinery(Team);
	bool RefDead = Commands->Get_Health(Ref) == 0.0f;
	bool HarvDead = Commands->Get_Health(Find_Harvester(Team)) == 0.0f;

//	Console_Output("HarvDead = %d, HarvHealth = %f, RefDead = %d, Ref = %x, Harv = %x", HarvDead,  Commands->Get_Health(Find_Harvester(Team)),
//		RefDead, Ref, Find_Harvester(Team)); // DEBUG CRAP

	// Build a new Harvester if needed
	if ( HarvDead && !RefDead )
	{
		Request_New_Harvester(Team);
	}

	// Needed for re-initialisation and also updating the state of the buidling
	((BuildingGameObj*)Building)->Collect_Building_Components();
	Update_Network_Object(Building);

	Update_Building_State(Building, false);
	Update_Network_Object(Building);

	Initialize_Building(Building);
	Update_Network_Object(Building);

	auto c = BaseControllerClass::Find_Base(Team);
	c->Set_Object_Dirty_Bit(NetworkObjectClass::BIT_RARE, true);
	Update_Network_Object(c);
}

void SCRIPTS_API Restore_Building(GameObject* obj) 
{
	if (!obj) return;
	
	BuildingGameObj* building = obj->As_BuildingGameObj();
	if (!building || !building->Is_Destroyed())
		return;

	building->Set_Is_Destroyed(false);

	BaseControllerClass* base = BaseControllerClass::Find_Base(Get_Object_Type(building));
	if (base) 
	{
		if (building->As_SoldierFactoryGameObj())
			base->Set_Can_Generate_Soldiers(true);
		
		if (building->As_VehicleFactoryGameObj())
			base->Set_Can_Generate_Vehicles(true);
		
		base->Set_Object_Dirty_Bit(NetworkObjectClass::BIT_RARE, true);
	}
}

void Revive_Building(GameObject *Building)
{
	if (Building == nullptr || !Is_Building_Dead(Building)) return;

	Restore_Building(Building); //Scripts API call already sets BIT_RARE and I assume Set_Is_Destroyed does the 0x778 offset bool or something similar.

	float max = Commands->Get_Max_Health(Building);
	Commands->Set_Health(Building, max);

	//The remaining stuff; restore power, harvester, w/e
}

561A8A63   84DB             TEST BL,BL // contains IsDestroyed sent by server
561A8A65   74 17            JE SHORT tt.561A8A7E // if false jump past this code to Out
561A8A67   80BE 70070000 00 CMP BYTE PTR DS:[ESI+770],0 // Check client IsDetroyed
561A8A6E   75 0E            JNZ SHORT tt.561A8A7E // if IsDestroyed is true jump to Out, only execute the below call if false
561A8A70   8B56 F8          MOV EDX,DWORD PTR DS:[ESI-8]
561A8A73   8B82 94000000    MOV EAX,DWORD PTR DS:[EDX+94]
561A8A79   8D4E F8          LEA ECX,DWORD PTR DS:[ESI-8]
561A8A7C   FFD0             CALL EAX // call BuildingGameObj::On_Destroyed()

// Out:
561A8A7E   889E 70070000    MOV BYTE PTR DS:[ESI+770],BL // I memory patched this in, this sets client IsDetroyed with what server sends
561A8A84   90               NOP
561A8A85   90               NOP
561A8A86   90               NOP
561A8A87   5F               POP EDI // Normal epilogue
561A8A88   5E               POP ESI
561A8A89   5B               POP EBX
561A8A8A   8BE5             MOV ESP,EBP
561A8A8C   5D               POP EBP
561A8A8D   C2 0400          RETN 4

mov     al, [esp+20h+var_11]
test    al, al
jz      short loc_68431E
mov     al, [ebx+770h]
test    al, al
jnz     short loc_68431E
mov     edx, [ebx-8]
lea     ecx, [ebx-8]
call    dword ptr [edx+94h]


pop     edi
pop     esi
pop     ebx
add     esp, 14h
retn    4

mov     al, [esp+20h+var_11]
test    al, al

jz      short loc_68431E
mov     al, [ebx+770h]

64E016C9   8B7424 14        MOV ESI,DWORD PTR SS:[ESP+14]
64E016CD   8A46 0B          MOV AL,BYTE PTR DS:[ESI+B]
64E016D0   8886 70070000    MOV BYTE PTR DS:[ESI+770],AL
64E016D6   5F               POP EDI
64E016D7   5E               POP ESI
64E016D8   5B               POP EBX
64E016D9   83C4 14          ADD ESP,14
64E016DC   C2 0400          RETN 4
64E016DD   CC               INT3