Command and Conquer: Renegade Official Forums: Tiberian Technologies Forum » BRenBot

Home » Tiberian Technologies / Blackhand Studios » Tiberian Technologies Forum » BRenBot

Show: Today's Messages :: Polls :: Message Navigator

BRenBot [message #472314]

Sat, 28 July 2012 18:09

Xpert
Messages: 1588
Registered: December 2005
Location: New York City

Karma: 0

General (1 Star)

Is stupid stuff like this ever going to be fixed?

Quote:

[20:47:36] <x_X> !msg was kicked
[20:47:37] <JellyMarathon> Host: (x_X@IRC): was kicked
[20:47:37] <JellyMarathon> Host: (x_X@IRC): was kicked

Quote:

[20:47:12] <JellyMarathon> MUDKIPS: [02:00:26] <&JellyMarathon> Player DickClark joined the game
[20:47:12] <JellyMarathon> MUDKIPS: [02:00:26] <&JellyMarathon> Player DickClark joined the game
[20:47:13] <JellyMarathon> Host: [DickClark] every game is a MUST WIN with WINclark
[20:47:13] <JellyMarathon> [Team] Wizard17: so we lost both lt tanks in the last go round?
[20:47:13] <JellyMarathon> MUDKIPS: [02:00:26] <&JellyMarathon> Player DickClark joined the game
[20:47:13] <JellyMarathon> MUDKIPS: [02:00:26] <&JellyMarathon> Player DickClark joined the game
[20:47:13] <JellyMarathon> Host: [DickClark] every game is a MUST WIN with WINclark
[20:47:14] <JellyMarathon> [Team] Alphafat: back of the barracks c4-ed in case they try apc rush
[20:47:14] <JellyMarathon> MUDKIPS: [02:00:26] <&JellyMarathon> Player DickClark joined the game
[20:47:14] <JellyMarathon> MUDKIPS: [02:00:26] <&JellyMarathon> Player DickClark joined the game
[20:47:14] <JellyMarathon> Host: [DickClark] every game is a MUST WIN with WINclark
[20:47:14] <JellyMarathon> MUDKIPS: [02:00:26] <&JellyMarathon> Player DickClark joined the game
[20:47:14] <JellyMarathon> MUDKIPS: [02:00:26] <&JellyMarathon> Player DickClark joined the game
[20:47:14] <JellyMarathon> Host: [DickClark] every game is a MUST WIN with WINclark
[20:47:17] <JellyMarathon> Host: [BR] DickClark is cooking up some nuclear strike bacon. (672 recommendations)

Basically, if you do things that mimic the bot in or out of game, the bot will respond to it as if it's a legit message coming from the FDS such as when someone joins the server or when someone gets kicked.

http://i32.photobucket.com/albums/d42/XpertMaverick/xpertyankee.jpg

Creator of NetGuard, an IRC network regulator.
Developer of the CloudyServ 0.982-X project.
Developer of the CloudyServ Ren-X bot.

Part time streamer - https://twitch.tv/gg_wonder

Report message to a moderator

Re: BRenBot [message #472317 is a reply to message #472314]

Sat, 28 July 2012 19:45

Sean
Messages: 822
Registered: February 2009

Karma: 0

Colonel

Xpert wrote on Sat, 28 July 2012 18:09

Is stupid stuff like this ever going to be fixed?

Quote:

[20:47:36] <x_X> !msg was kicked
[20:47:37] <JellyMarathon> Host: (x_X@IRC): was kicked
[20:47:37] <JellyMarathon> Host: (x_X@IRC): was kicked

Quote:

[20:47:12] <JellyMarathon> MUDKIPS: [02:00:26] <&JellyMarathon> Player DickClark joined the game
[20:47:12] <JellyMarathon> MUDKIPS: [02:00:26] <&JellyMarathon> Player DickClark joined the game
[20:47:13] <JellyMarathon> Host: [DickClark] every game is a MUST WIN with WINclark
[20:47:13] <JellyMarathon> [Team] Wizard17: so we lost both lt tanks in the last go round?
[20:47:13] <JellyMarathon> MUDKIPS: [02:00:26] <&JellyMarathon> Player DickClark joined the game
[20:47:13] <JellyMarathon> MUDKIPS: [02:00:26] <&JellyMarathon> Player DickClark joined the game
[20:47:13] <JellyMarathon> Host: [DickClark] every game is a MUST WIN with WINclark
[20:47:14] <JellyMarathon> [Team] Alphafat: back of the barracks c4-ed in case they try apc rush
[20:47:14] <JellyMarathon> MUDKIPS: [02:00:26] <&JellyMarathon> Player DickClark joined the game
[20:47:14] <JellyMarathon> MUDKIPS: [02:00:26] <&JellyMarathon> Player DickClark joined the game
[20:47:14] <JellyMarathon> Host: [DickClark] every game is a MUST WIN with WINclark
[20:47:14] <JellyMarathon> MUDKIPS: [02:00:26] <&JellyMarathon> Player DickClark joined the game
[20:47:14] <JellyMarathon> MUDKIPS: [02:00:26] <&JellyMarathon> Player DickClark joined the game
[20:47:14] <JellyMarathon> Host: [DickClark] every game is a MUST WIN with WINclark
[20:47:17] <JellyMarathon> Host: [BR] DickClark is cooking up some nuclear strike bacon. (672 recommendations)

Basically, if you do things that mimic the bot in or out of game, the bot will respond to it as if it's a legit message coming from the FDS such as when someone joins the server or when someone gets kicked.

Instead of qqing about errors, why don't you get Jelly to run your CloudyServ since it's superior in your opinion.

Head admin at TmX (The Matrix Sniper server)

irc.thematrixserver.com
The Matrix Sniper: 188.138.84.134:4576

Report message to a moderator

Re: BRenBot [message #472318 is a reply to message #472314]

Sat, 28 July 2012 20:04

Distrbd21
Messages: 743
Registered: September 2008

Karma: 0

Colonel

lol at sig az ^_^

Live Your Life Not Some one Else's.| Sharing Is Caring

http://dsgaming.us/distrbd21/Distrbd21%20siggy.png

Report message to a moderator

Re: BRenBot [message #472321 is a reply to message #472314]

Sat, 28 July 2012 22:24

Ethenal
Messages: 2532
Registered: January 2007
Location: US of A

Karma: 0

General (2 Stars)

Ethenal@GMail.com

I had to reveal your post from ignore to read it, and naturally I regretted doing so. Jelly is certainly not going to run CloudyServ.

I don't know why you're saying "qqing about errors" because he discovered one that can actually remove a user's temporary moderator not to mention probably regular moderator status too. They're actually pretty bad bugs.

-TLS-DJ-EYE-K wrote on Mon, 18 March 2013 07:29

Instead of showing us that u aren't more inteligent than a Toast, maybe you should start becomming good in renegade Thumbs Up

Thumbs Up

Report message to a moderator

Re: BRenBot [message #472326 is a reply to message #472317]

Sun, 29 July 2012 00:11

Xpert
Messages: 1588
Registered: December 2005
Location: New York City

Karma: 0

General (1 Star)

Azazel wrote on Sat, 28 July 2012 22:45

Instead of qqing about errors, why don't you get Jelly to run your CloudyServ since it's superior in your opinion.

Instead of adding input that doesn't help fix this problem, how about you not comment any further.

There are numerous dumb bugs in BRenBot that can cause problems. I already exploited a few on Jelly while testing to see if the bugs still exist and they infact do.

Not to mention using !page to crash the server and being able to change things like people's setjoins without even being on their name. It's a huge backdoor and I can pretty much exploit any 4.0 server running BRenBot with simple sentences the bot would usually read off the FDS.

http://i32.photobucket.com/albums/d42/XpertMaverick/xpertyankee.jpg

Creator of NetGuard, an IRC network regulator.
Developer of the CloudyServ 0.982-X project.
Developer of the CloudyServ Ren-X bot.

Part time streamer - https://twitch.tv/gg_wonder

Report message to a moderator

Re: BRenBot [message #472348 is a reply to message #472314]

Mon, 30 July 2012 01:13

danpaul88
Messages: 5795
Registered: June 2004
Location: England

Karma: 0

General (5 Stars)

Well if people would actually report bugs I might be able to fix them. First I have heard of any of these, if you want to actually give me exact reproduction steps I will look into fixing them.

It's no good jumping up and down frothing at the mouth about things not being fixed if you have never bothered to report them as bugs in the first place... Sarcasm

Sarcasm

http://steamsignature.com/card/1/76561197975867233.png

Report message to a moderator

Re: BRenBot [message #472349 is a reply to message #472314]

Mon, 30 July 2012 02:02

cAmpa
Messages: 597
Registered: March 2006

Karma: 0

Colonel

Quote:

[10:58:11] <@AOW> Initializing Ren Mode: hi
[10:58:11] <@AOW> Initializing Ren Mode: hi
[10:58:12] <@AOW> BoorMachine killed theirself.
[10:58:18] <@AOW> Initializing Ren Mode purchased a vehicle
[10:58:31] <@AOW> Initializing Ren Mode: !version
[10:58:31] <@AOW> Initializing Ren Mode: !version
[10:58:31] <@AOW> Host: [BR] I'm running BRenBot 1.53 (build 11).
[10:58:31] <@AOW> Host: [BR] BRenBot is Copyright 2003-2012 by Tiberian Technologies. All rights reserved.
[10:59:00] <@AOW> Host: [BR] [TRCU]Great_Spanish has stolen a GDI Humvee!
[10:59:08] <@AOW> Host: [BR] Initializing Ren Mode has stolen a GDI Humvee!
[10:59:17] <@AOW> Initializing Ren Mode: m
[10:59:17] <@AOW> Initializing Ren Mode: m

;P

BÃ¼ckstabÃ¼!

Report message to a moderator

Re: BRenBot [message #472350 is a reply to message #472314]

Mon, 30 July 2012 02:23

Gen_Blacky
Messages: 3250
Registered: September 2006

Karma: 1

General (3 Stars)

Basically anything and everything in renlog you can exploit with player name or sending a msg to the fds!

Initializing .+ Mode

Loading level .+

Level loaded OK

Ect.

Surprised no one said anything before, thought you knew..................... You could do this for a long time. pre br 1.52

http://s18.postimage.org/jc6qbn4k9/bricks3.png

[Updated on: Mon, 30 July 2012 02:36]

Report message to a moderator

Re: BRenBot [message #472352 is a reply to message #472314]

Mon, 30 July 2012 02:50

danpaul88
Messages: 5795
Registered: June 2004
Location: England

Karma: 0

General (5 Stars)

That's due to a limitation of renlog whereby for some messages it is actually impossible to determine programatically whether a given string is an ingame message from a player or something else, due to the fact chat messages don't have a uniquely recognizable format.

For instance, the following string;

My: Name: Is: Fred

Can either be;

A player with the name "My" saying "Name: Is: Fred"
A player with the name "My: Name" saying "Is: Fred"
A player with the name "My Name: Is" saying "Fred"

There's simply no way to tell the difference due to the lack of any unique symbols in the message that players are unable to use in their usernames to determine the correct location for the split.

This becomes worse when you get things like;

Player: was kicked

This is either;

A player with the name "Player:" being kicked from the game
A player with the name "Player" saying "was kicked"

To a human it might be obvious which it is, but for a regular expression it could easily be either of the two. Westwood unfortunately created a rather ambiguous format for the renlog file which results in these cases where it's not possible to tell what a message is supposed to be.

For some cases I might be able to tighten up some of the regexes where the 'variable' parts have a finite number of possible known values (ie: Initialising WOL/GSA Mode) but other cases are less clear cut.

But, for the record, this is indeed the first time anyone has ever bothered reporting this as an issue, I was unaware there were any problems with Renlog parsing in the 1.53.* versions of BRenBot.

http://steamsignature.com/card/1/76561197975867233.png

Report message to a moderator

Re: BRenBot [message #472353 is a reply to message #472314]

Mon, 30 July 2012 03:21

Gen_Blacky
Messages: 3250
Registered: September 2006

Karma: 1

General (3 Stars)

the simple fix would be to add new chat msg output for ssgm 4.0 so its easy to determine what is what.
I wouldn't really worry about backwards compatibility other then 4.0 servers.

Not allowing players to have spaces in their names fixes most of the problems.
Then filtering out msg's from players to not send to renlog.

Having stricter regex matches like you said would help.

if ( $line =~ /^Initializing .+ Mode/ )
to
if ( $line =~ /^Initializing\s.+\sMode$/ )

Initializing LAN Mode
Initializing GameSpy Mode
Initializing Westwood Online Mode

like this would fix if a player name was "Initializing .+ Mode" but not if the player said "Initializing .+ Mode" while their name is "Initializing .+ Mode"

"Initializing REN Mode: Initializing v Mode" would trigger
"Initializing REN Mode: blah" wouldn't
"PlayerName: Initializing REN Mode" wouldn't

Just try to narrow down all the regex in renlog I guess.

http://s18.postimage.org/jc6qbn4k9/bricks3.png

[Updated on: Mon, 30 July 2012 04:36]

Report message to a moderator

Re: BRenBot [message #472356 is a reply to message #472314]

Mon, 30 July 2012 04:38

StealthEye
Messages: 2518
Registered: May 2006
Location: The Netherlands

Karma: 0

General (2 Stars)

Why don't we just block player names that contain a colon and update the regexes to disallow colon matching in names? Would that not solve all/most of the ambiguity?

I was actually under the impression that nicks containing colons or spaces were already blocked, but that does not seem to be the case.

BlackIntel admin/founder/coder
Please visit http://www.blackintel.org/

[Updated on: Mon, 30 July 2012 04:41]

Report message to a moderator

Re: BRenBot [message #472360 is a reply to message #472314]

Mon, 30 July 2012 05:11

danpaul88
Messages: 5795
Registered: June 2004
Location: England

Karma: 0

General (5 Stars)

It would certainly help. BRenBot does disallow some characters already, I'm surprised the colon isn't one of them actually.

http://steamsignature.com/card/1/76561197975867233.png

Report message to a moderator

Re: BRenBot [message #472364 is a reply to message #472356]

Mon, 30 July 2012 07:18

Ethenal
Messages: 2532
Registered: January 2007
Location: US of A

Karma: 0

General (2 Stars)

Ethenal@GMail.com

StealthEye wrote on Mon, 30 July 2012 06:38

Why don't we just block player names that contain a colon and update the regexes to disallow colon matching in names? Would that not solve all/most of the ambiguity?

I was actually under the impression that nicks containing colons or spaces were already blocked, but that does not seem to be the case.

I thought so too, I've seen code in scripts.dll (4.) somewhere that checks nicknames and removes them if there are characters it doesn't like... BRenBot also does its own nickname checking as well.

Btw, since you're looking at this danpaul, did BR ever fill in the $args{settings} hash for plugins? It works in the stock commands, but not in plugins (for me at least).

-TLS-DJ-EYE-K wrote on Mon, 18 March 2013 07:29

Instead of showing us that u aren't more inteligent than a Toast, maybe you should start becomming good in renegade Thumbs Up

Thumbs Up

Report message to a moderator

Re: BRenBot [message #472369 is a reply to message #472364]

Mon, 30 July 2012 08:00

danpaul88
Messages: 5795
Registered: June 2004
Location: England

Karma: 0

General (5 Stars)

Ethenal wrote on Mon, 30 July 2012 15:18

Btw, since you're looking at this danpaul, did BR ever fill in the $args{settings} hash for plugins? It works in the stock commands, but not in plugins (for me at least).

Not sure to be honest, remind me to have a look at the code sometime. I am at work at the moment so don't have access to my SVN (bloody proxies...)

http://steamsignature.com/card/1/76561197975867233.png

Report message to a moderator

Re: BRenBot [message #472625 is a reply to message #472314]

Thu, 02 August 2012 00:34

danpaul88
Messages: 5795
Registered: June 2004
Location: England

Karma: 0

General (5 Stars)

I'm hoping to get some time to work on this sort of stuff over the weekend, so if anyone is sitting on any other unreported bugs now would be a good time to report them. Ditto for anything reported a long time ago that's not been fixed, odds are I forgot about it. Feel free to remind me.

http://steamsignature.com/card/1/76561197975867233.png

Report message to a moderator

Re: BRenBot [message #472724 is a reply to message #472356]

Fri, 03 August 2012 07:49

Lazy5686
Messages: 254
Registered: November 2007

Karma: 0

Recruit

StealthEye wrote on Mon, 30 July 2012 04:38

Why don't
I was actually under the impression that nicks containing colons or spaces were already blocked, but that does not seem to be the case.

Spaces are not, we've been running a plugin for years that changes them to underscores.

The Scruffy, AngryCanadian with Vuvuzelas
-Jelly Games admin

http://i.imgur.com/7RiVG.jpg

Report message to a moderator

Re: BRenBot [message #472804 is a reply to message #472314]

Sat, 04 August 2012 23:57

Ani
Messages: 399
Registered: February 2012
Location: New York City

Karma: 0

Commander

Since we're talking about improving BRenBot, I have 2 suggestions:

1) Add an option to where if there is below a certain amount of players in-game player recommendations & rank stats don't get updated.

2) Limit the amount of spam that can be created from repeatedly hitting Page Up/Down for polls...

Just my 2 cents..

Report message to a moderator

Re: BRenBot [message #472805 is a reply to message #472314]

Sun, 05 August 2012 00:04

Gen_Blacky
Messages: 3250
Registered: September 2006

Karma: 1

General (3 Stars)

Update player gameobejct ids if bot stars in middle of game. Like use LISTPLAYERSOBJECTIDS from reborns console commands or send the on CREATED;SOLDIER log.

http://s18.postimage.org/jc6qbn4k9/bricks3.png

Report message to a moderator

Re: BRenBot [message #472817 is a reply to message #472804]

Sun, 05 August 2012 04:24

danpaul88
Messages: 5795
Registered: June 2004
Location: England

Karma: 0

General (5 Stars)

Ani wrote on Sun, 05 August 2012 07:57

2) Limit the amount of spam that can be created from repeatedly hitting Page Up/Down for polls...

That's not BRenBot doing that... so nothing I can do about it. Key hooks are done in server side code.

http://steamsignature.com/card/1/76561197975867233.png

[Updated on: Sun, 05 August 2012 04:26]

Report message to a moderator

Re: BRenBot [message #472818 is a reply to message #472805]

Sun, 05 August 2012 04:27

danpaul88
Messages: 5795
Registered: June 2004
Location: England

Karma: 0

General (5 Stars)

Gen_Blacky wrote on Sun, 05 August 2012 08:04

Update player gameobejct ids if bot stars in middle of game. Like use LISTPLAYERSOBJECTIDS from reborns console commands or send the on CREATED;SOLDIER log.

I'm not sure what you mean by this? GameObject IDs are already updated on the CREATED logs.

http://steamsignature.com/card/1/76561197975867233.png

Report message to a moderator

Re: BRenBot [message #472819 is a reply to message #472818]

Sun, 05 August 2012 04:39

cAmpa
Messages: 597
Registered: March 2006

Karma: 0

Colonel

danpaul88 wrote on Sun, 05 August 2012 13:27

Gen_Blacky wrote on Sun, 05 August 2012 08:04

Update player gameobejct ids if bot stars in middle of game. Like use LISTPLAYERSOBJECTIDS from reborns console commands or send the on CREATED;SOLDIER log.

I'm not sure what you mean by this? GameObject IDs are already updated on the CREATED logs.

I think he means, when the bot starts in the middle of the game, it needs to wait for the next CREATED;SOLDIER to get the player information.

BÃ¼ckstabÃ¼!

Report message to a moderator

Re: BRenBot [message #472832 is a reply to message #472314]

Sun, 05 August 2012 10:18

danpaul88
Messages: 5795
Registered: June 2004
Location: England

Karma: 0

General (5 Stars)

Well, that was never considered a high priority thing to look into because it's uncommon to restart the bot in the middle of a game. Normally the bot and FDS are loaded at the same time and thus all CREATED:blah gamelog entries would be read by the bot for the first map in the rotation.

http://steamsignature.com/card/1/76561197975867233.png

Report message to a moderator

Re: BRenBot [message #472834 is a reply to message #472314]

Sun, 05 August 2012 10:30

Ani
Messages: 399
Registered: February 2012
Location: New York City

Karma: 0

Commander

What about

Quote:

Add an option to where if there is below a certain amount of players in-game player recommendations & rank stats don't get updated.

Report message to a moderator

Re: BRenBot [message #472835 is a reply to message #472314]

Sun, 05 August 2012 10:34

danpaul88
Messages: 5795
Registered: June 2004
Location: England

Karma: 0

General (5 Stars)

Ranks are part of a plugin and not BRenBot itself, I am currently focussing on core BRenBot features rather than plugin updates. That said it should be easy to add that option, there's already one for 'minimum score' for a player to be ranked in a given game (and it also won't rank you if there is only one team in the game, just FYI).

As for recommendations, you can alter the thresholds at which recommendations are given in the brenbot.cfg file, it shouldn't be hard to find values high enough to effectively prevent them being given in small games.

http://steamsignature.com/card/1/76561197975867233.png

Report message to a moderator

Re: BRenBot [message #472855 is a reply to message #472832]

Sun, 05 August 2012 14:02

Gen_Blacky
Messages: 3250
Registered: September 2006

Karma: 1

General (3 Stars)

danpaul88 wrote on Sun, 05 August 2012 11:18

Well, that was never considered a high priority thing to look into because it's uncommon to restart the bot in the middle of a game. Normally the bot and FDS are loaded at the same time and thus all CREATED:blah gamelog entries would be read by the bot for the first map in the rotation.

Yea its not a big deal. functions like getPlayerFromObjectID wont work until the player gets killed or they change characters. Most of the gamelog stuff wont work or ranks wont work correctly.

I have just seen jelly restart brenbot in middle of game. Their usually are people with the last hotwire or something. On jelly marathon it could be hours before they are killed. They wont achieve any recommendations or have their rankstats updated ect, until a new game starts.

Just thought i would mention it.

http://s18.postimage.org/jc6qbn4k9/bricks3.png

[Updated on: Sun, 05 August 2012 14:03]

Report message to a moderator

Pages (2): [1 2 › »]

Previous Topic:	AGT
Next Topic:	Crash dump

Goto Forum:

-=] Back to Top [=-

[ Syndicate this forum (XML) ] [

] [

PDF

]

Current Time: Sun Dec 22 18:25:58 MST 2024

Total time taken to generate the page: 0.01385 seconds